瀏覽代碼

fix panic when clear labels and Closes #16

Yoginth 7 年之前
父節點
當前提交
605ac17f1c
共有 1 個文件被更改,包括 7 次插入2 次删除
  1. 7 2
      models/issue.go

+ 7 - 2
models/issue.go

@@ -311,8 +311,13 @@ func (issue *Issue) clearLabels(e *xorm.Session) (err error) {
 		return fmt.Errorf("getLabels: %v", err)
 	}
 
-	for len(issue.Labels) > 0 {
-		if err = issue.removeLabel(e, issue.Labels[0]); err != nil {
+	// NOTE: issue.removeLabel slices issue.Labels, so we need to create another slice to be unaffected.
+	labels := make([]*Label, len(issue.Labels))
+	for i := range issue.Labels {
+		labels[i] = issue.Labels[i]
+	}
+	for i := range labels {
+		if err = issue.removeLabel(e, labels[i]); err != nil {
 			return fmt.Errorf("removeLabel: %v", err)
 		}
 	}