|
@@ -52,7 +52,7 @@ Some existing code may be poorly written or untested, so we must have more scrut
|
|
|
* Try to keep the pull requests small. A pull request should try its very best to address only a single concern.
|
|
* Try to keep the pull requests small. A pull request should try its very best to address only a single concern.
|
|
|
* Make sure all tests pass and add additional tests for the code you submit.
|
|
* Make sure all tests pass and add additional tests for the code you submit.
|
|
|
* Document your reasoning behind the changes. Explain why you wrote the code in the way you did. The code should explain what it does.
|
|
* Document your reasoning behind the changes. Explain why you wrote the code in the way you did. The code should explain what it does.
|
|
|
-* If there's an existing issue related to the pull request, reference to it by adding something like `References/Closes/Fixes/Resolves #305`, where 305 is the issue number. [More info here](https://docs.gitlab.com/ee/user/project/issues/closing_issues.html#via-merge-request)
|
|
|
|
|
|
|
+* If there's an existing issue related to the pull request, reference to it by adding something like `References/Closes/Fixes/Resolves #305`, where 305 is the issue number.
|
|
|
* If you follow the pull request template, you can't go wrong.
|
|
* If you follow the pull request template, you can't go wrong.
|
|
|
|
|
|
|
|
## Codebase
|
|
## Codebase
|
Yoginth